Fix Deployment Test Syntax bug #568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PacificGilly
force-pushed
the
jamesgilmore/fix-deployment-test-syntax-bug
branch
12 times, most recently
from
b3e1f9b
to
2af7c65
Compare
I guess for this exact reason is why it will be useful to have this `pre-release.yml` file being ran on PRs to validate nothing gets broken before merging :)
PacificGilly
force-pushed
the
jamesgilmore/fix-deployment-test-syntax-bug
branch
from
2af7c65
to
ac19db3
Compare
|
@farridav let me know what you think of this deployment change to ensure less issues after merging to master. There is a strange issue with the https://github.com/farridav/django-jazzmin/actions/runs/8782873944/job/24097897693 I don't really understand why this is occurring; it is potentially caused by secrets that are not visible to PRs. |
|
Nevermind, this seems to be by design - https://securitylab.github.com/research/github-actions-preventing-pwn-requests/. Makes sense now I've read this 😅 Anyway, I'll just remove this last check as the others are good enough. |
farridav
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I guess for this exact reason is why it will be useful to have this
pre-release.ymlfile being ran on PRs to validate nothing gets broken before merging :)