Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POST requests should respond with 201 status code #107

Open
paul121 opened this issue Nov 19, 2020 · 0 comments
Open

POST requests should respond with 201 status code #107

paul121 opened this issue Nov 19, 2020 · 0 comments
Labels
2x farmOS 2x support

Comments

@paul121
Copy link
Member

paul121 commented Nov 19, 2020

Most of the POST requests respond with 200. I think that most of these should return a 201 instead, because they are "creating" a farm profile, access token, authorization link, etc. This would be a breaking change so might need to wait until the 2x endpoint is in place to add this.

One hesitation are the endpoints for farmOS records such as api/v1/farms/logs. What happens if the request only succeeds on some servers? Is this considered success?

@paul121 paul121 added the 2x farmOS 2x support label Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2x farmOS 2x support
Development

No branches or pull requests

1 participant