Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metric Arguments in compare_* methods is confusing #31

Open
farhanreynaldo opened this issue Aug 29, 2022 · 0 comments
Open

Metric Arguments in compare_* methods is confusing #31

farhanreynaldo opened this issue Aug 29, 2022 · 0 comments

Comments

@farhanreynaldo
Copy link
Owner

The argument for metrics across the compare_* methods is inconsistent. The compare_ttest have the numerator argument, which is confusing since it mimics the naming convention for compare_delta. There should be more intuitive naming for the metrics that work across all compare_* methods.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant