migrate link store #91
Conversation
| let prefix: Vec<u8> = LinkStore::links_by_target_key(target, 0, None)?; | ||
| let start_prefix: Vec<u8> = LinkStore::links_by_target_key(target, 0, None)?; | ||
| let stop_target = match target { | ||
| Target::TargetFid(fid) => Target::TargetFid(fid + 1), |
There was a problem hiding this comment.
Use increment_vec_u8, which is more generic.
There was a problem hiding this comment.
I actually preferred this method. With increment_vec_u8 you need to be sure that the key you're incrementing is the last part of the prefix otherwise it won't do what you want. Here, I actually had increment_vec_u8 first but then checked the key structure and saw that the target fid is somewhere in the middle of the prefix so I changed it.
There was a problem hiding this comment.
I actually just made the change you suggested in my next feature. In that one, there's some string field we index on and it was hard to figure out how to increment that. I just changed this to be consistent too.
| let next_page_token = if last_key.len() > 0 { | ||
| Some(last_key[prefix.len()..].to_vec()) |
There was a problem hiding this comment.
Hmm, why did this change?
There was a problem hiding this comment.
This changed at the db level when I pulled the db code in. The page token is the whole key and not a piece of it. Only providing the suffix in the token worked when we only iterated over a single prefix (e.g. fid) but now that we have a start and stop we can't keep only some suffix.
| pub fn get_link_removes_by_fid( | ||
| store: &Store, | ||
| store: &Store<LinkStore>, |
There was a problem hiding this comment.
Why did these change? Not a big deal, but we should keep it consistent with hubs if possible. The CastStore uses just Store
There was a problem hiding this comment.
I changed the cast store too earlier. The reason i did this is because deriving works better with the generic. I wanted to derive Clone and couldn't do it with the version that existed before because of the way we embedded the store with Box and dyn.
Support link messages in the engine.