Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make add location more like edit location process #604

Open
ezwelty opened this issue Nov 17, 2024 · 1 comment · May be fixed by #658
Open

Make add location more like edit location process #604

ezwelty opened this issue Nov 17, 2024 · 1 comment · May be fixed by #658
Assignees
Labels
bug Unexpected problems or unintended behavior enhancement New feature request mobile Specific to mobile layout

Comments

@ezwelty
Copy link
Collaborator

ezwelty commented Nov 17, 2024

When adding a location, going back from the location form (/locations/new) to the map to set a location (/locations/init), and back to the form results in a blank form. In other words, it isn't possible to adjust the location position without restarting the whole add-location process.

I propose that it should be possible to adjust the position of a new location without losing form content. I suggest that this can be accomplished by treating the add-location form in a similar same way as the edit-location form, such that the location position is orange and links to the edit-position page, and (unlike edit-location) clicking on back does the same.

@ezwelty ezwelty added bug Unexpected problems or unintended behavior enhancement New feature request mobile Specific to mobile layout labels Nov 17, 2024
@wbazant
Copy link
Collaborator

wbazant commented Dec 14, 2024

I agree with the crux of the issue - allowing the adjustment of the position - and there would be other usability benefits to also making it possible to go back -> settings -> language, or back -> sign in.

Not sure whether also making the edit location orange also for adding location is good or not - it produces consistency between the forms, but offering multiple ways to do the same thing can be confusing.

Implementation note: there's already functionality to save form contents and bring it back, so this shouldn't be too bad to solve!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Unexpected problems or unintended behavior enhancement New feature request mobile Specific to mobile layout
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants