Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add/edit review still using deprecated 2-step form #415

Closed
ezwelty opened this issue Jul 3, 2024 · 2 comments
Closed

Add/edit review still using deprecated 2-step form #415

ezwelty opened this issue Jul 3, 2024 · 2 comments
Labels
bug Unexpected problems or unintended behavior good first issue Good for newcomers mobile Specific to mobile layout refactoring Internal changes to code aesthetic or structure

Comments

@ezwelty
Copy link
Collaborator

ezwelty commented Jul 3, 2024

Although on mobile "add location" is a single form (that combines location and review properties), "add/edit review" still uses a 2-step form (which, as a bug, is not scrollable on small screens). It should be replaced with the review section of the form used in "add location".

Add review

Add location
@ezwelty ezwelty added bug Unexpected problems or unintended behavior good first issue Good for newcomers mobile Specific to mobile layout labels Jul 3, 2024
@ezwelty ezwelty added the refactoring Internal changes to code aesthetic or structure label Aug 13, 2024
@wbazant
Copy link
Collaborator

wbazant commented Aug 27, 2024

I'm touching the review code so I might fix this issue- src/components/mobile/MobileLayout.js has "<EditReviewForm stepped ..." and I think just removing the argument and tidying up will do it.

This was referenced Aug 29, 2024
Closed
Merged
@wbazant
Copy link
Collaborator

wbazant commented Sep 26, 2024

This is now working as proposed on the live site.

@wbazant wbazant closed this as completed Sep 26, 2024
@wbazant wbazant mentioned this issue Dec 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Unexpected problems or unintended behavior good first issue Good for newcomers mobile Specific to mobile layout refactoring Internal changes to code aesthetic or structure
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ezwelty @wbazant