Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mobile: "add new location" state is lost when going to settings and back #407

Closed
wbazant opened this issue Jun 20, 2024 · 1 comment
Closed
Labels
bug Unexpected problems or unintended behavior enhancement New feature request
Milestone

Comments

@wbazant
Copy link
Collaborator

wbazant commented Jun 20, 2024

When adding a location, a user might want to switch to a satellite view or turn labels on.

This issue could be addressed by the click handler for "Map" sometimes routing to the new location page.

It could also be good to also allow switching to the satellite view when viewing the location - the menu is currently occluded by the drawer, so it would require a different UI design - a drawer from the left?

Related to #406 (comment).

@ezwelty
Copy link
Collaborator

ezwelty commented Jul 3, 2024

"Settings" is not accessible during any location interaction (view, add, edit, review, report) because on desktop the location pane covers the entire left sidebar (including the Settings footer), and on mobile the location drawer comes up from below and covers the entire footer navigation.

The simplest UI fix on desktop would be to prevent the location pane from covering the Settings footer.

On mobile, I would have suggested placing the settings button in the top left, which remains visible when the location drawer is half-open, but this is covered by the instruction message when setting position for new/existing location. Since map switching is most important when setting location position, maybe it is sufficient for now to focus on changing the behavior of the existing Settings footer button: it opens a drawer from the left rather than switching to a new route?

...

Here is how this looks on the current mobile app. Setting in the top left opens a drawer with a close X at the same location (to facilitate quickly opening and closing the drawer). The drawer includes both settings and the location filters, which were split in the current design to accommodate an expanded type filter that remains always visible on desktop (although I note that populating the type counts drives a lot of extra API calls). There is no instruction message when setting position of new location, so it remains accessible. There is no swipe-from-left to open the drawer because I found this to be very fiddly and a button is still needed somewhere to make it clear to users.

@ezwelty ezwelty added bug Unexpected problems or unintended behavior enhancement New feature request labels Jul 3, 2024
@ezwelty ezwelty added this to the Beta release milestone Jul 3, 2024
@ezwelty ezwelty closed this as completed in 71691e8 Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Unexpected problems or unintended behavior enhancement New feature request
Projects
None yet
Development

No branches or pull requests

2 participants