-
-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(usersettings): add separate setting for streaming region #993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged. |
gauthier-th
force-pushed
the
feat-streaming-region
branch
from
November 12, 2024 21:37
dc4fb69
to
7aed0c6
Compare
gauthier-th
changed the title
feat: add separate setting for streaming region
feat(usersettings): add separate setting for streaming region
Nov 15, 2024
Currently, the "Currently Streaming On" information is based on the Discover Region setting. This PR adds a new setting to specify which region should be used to display the streaming region. re #890
gauthier-th
force-pushed
the
feat-streaming-region
branch
from
December 5, 2024 20:44
7aed0c6
to
1b74452
Compare
Fallenbagel
requested changes
Dec 7, 2024
Fallenbagel
approved these changes
Dec 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
9 tasks
thibodelanghe
pushed a commit
to thibodelanghe/jellyseerr
that referenced
this pull request
Dec 18, 2024
…bagel#993) * feat: add separate setting for streaming region Currently, the "Currently Streaming On" information is based on the Discover Region setting. This PR adds a new setting to specify which region should be used to display the streaming region. re Fallenbagel#890 * fix: add missing newline * fix: rename migration function
🎉 This PR is included in version 2.2.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, the "Currently Streaming On" information is based on the Discover Region setting. This PR adds a new setting to specify which region should be used to display the streaming region.
Screenshot (if UI-related)
New setting in general settings as well as in user settings:
To-Dos
pnpm build
pnpm i18n:extract
Issues Fixed or Closed