Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bypass cache-able lookups when resolving localhost #813

Merged
merged 2 commits into from
Jun 12, 2024

Conversation

Fallenbagel
Copy link
Owner

@Fallenbagel Fallenbagel commented Jun 12, 2024

Description

This PR aims to address an issue where DNS lookups for 'localhost' were timing out when using cacheable-lookup . 'localhost' lookups are now bypassing the cacheable DNS resolution.

Screenshot (if UI-related)

To-Dos

  • Successful build yarn build
  • Translation keys yarn i18n:extract
  • Database migration (if required)

Issues Fixed or Closed

  • Fixes #XXXX

gauthier-th
gauthier-th previously approved these changes Jun 12, 2024
@Fallenbagel Fallenbagel requested a review from gauthier-th June 12, 2024 22:18
@Fallenbagel Fallenbagel merged commit b5a0699 into develop Jun 12, 2024
8 checks passed
@Fallenbagel
Copy link
Owner Author

🎉 This PR is included in version 1.9.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

bonswouar pushed a commit to bonswouar/jellyseerr that referenced this pull request Jun 14, 2024
)

* fix: bypass cache-able lookups when resolving localhost

* fix: bypass cacheable-lookup when resolving localhost

---------

Co-authored-by: Gauthier <[email protected]>
@gauthier-th gauthier-th deleted the fix-dns-caching-localhost branch August 24, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants