Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Popup for unmatched series is broken #1075

Closed
1 task done
tmsholy opened this issue Nov 5, 2024 · 1 comment · Fixed by #1105
Closed
1 task done

Popup for unmatched series is broken #1075

tmsholy opened this issue Nov 5, 2024 · 1 comment · Fixed by #1105
Assignees
@gauthier-th
Labels
bug Something isn't working confirmed This bug has been reproduced released

Comments

@tmsholy
Copy link

tmsholy commented Nov 5, 2024

Description

I found a bug with a series that did not have the tvdb ID added. The popup for matching a series is missing images and the text is misplaced. I tried the same series in Overseerr and it does not have this issue.

Version

2.0.1

Steps to Reproduce

  1. Look up any series that does not have a linked tvdb ID on tmdb
  2. Click the request button
  3. Observe the popup window

Screenshots

Jellyseerr
Screenshot 2024-11-05 at 22 09 00

Overseerr
Screenshot 2024-11-05 at 22 09 13

Logs

No response

Platform

desktop

Device

Apple MacBook Pro 14"

Operating System

macOS 14.7.1 (Sonoma)

Browser

Firefox 132.0

Additional Context

No response

Code of Conduct

  • I agree to follow Jellyseerr's Code of Conduct
@tmsholy tmsholy added awaiting triage This issue needs to be reviewed bug Something isn't working labels Nov 5, 2024
@gauthier-th gauthier-th added confirmed This bug has been reproduced and removed awaiting triage This issue needs to be reviewed labels Nov 5, 2024
@gauthier-th gauthier-th self-assigned this Nov 6, 2024
gauthier-th added a commit that referenced this issue Nov 16, 2024
@gauthier-th
fix(ui): allow thetvdb images for unmatched series
5af3136 
When a series has no equivalent in TheTVDB used by Sonarr, a popup is displayed to select the series
on TheTVDB. The images in this popup come from artworks.thetvdb.com, which was not an authorized
domain for Next.js images.

fix #1075
@gauthier-th gauthier-th mentioned this issue Nov 16, 2024
Merged
3 tasks
gauthier-th added a commit that referenced this issue Nov 16, 2024
@gauthier-th
fix(ui): allow thetvdb images for unmatched series (#1105)
9b151fe 
When a series has no equivalent in TheTVDB used by Sonarr, a popup is displayed to select the series
on TheTVDB. The images in this popup come from artworks.thetvdb.com, which was not an authorized
domain for Next.js images.

fix #1075
thibodelanghe pushed a commit to thibodelanghe/jellyseerr that referenced this issue Dec 18, 2024
@gauthier-th @thibodelanghe
fix(ui): allow thetvdb images for unmatched series (Fallenbagel#1105)
3d684d2 
When a series has no equivalent in TheTVDB used by Sonarr, a popup is displayed to select the series
on TheTVDB. The images in this popup come from artworks.thetvdb.com, which was not an authorized
domain for Next.js images.

fix Fallenbagel#1075
@Fallenbagel
Copy link
Owner

🎉 This issue has been resolved in version 2.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gauthier-th gauthier-th

Labels
bug Something isn't working confirmed This bug has been reproduced released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(ui): allow thetvdb images for unmatched series Fallenbagel/jellyseerr
3 participants
@tmsholy @gauthier-th @Fallenbagel