wip: fix(build): properly fill up GRPC_LIBRARIES variable with all deps also when using system one

[FedeDP]

Signed-off-by: Federico Di Pierro [email protected]

What type of PR is this?

/kind bug

Any specific area of the project related to this PR?

/area build

What this PR does / why we need it:
It allows to build falco linking system grpc.
Note, however, that a PR is needed on falco too: falcosecurity/falco#1802

Which issue(s) this PR fixes:

Fixes #99

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

[poiana]

Hi @FedeDP. Thanks for your PR.

I'm waiting for a falcosecurity member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[poiana]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: FedeDP
To complete the pull request process, please assign leodido after the PR has been reviewed.
You can assign the PR to them by writing /assign @leodido in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[leogr]

/ok-to-test

[leogr]

I reserve some time to test in better, but after a quick look, it looks good to me!

Question: does it worth upgrading gRPC to the newest version directly in this PR?

[FedeDP]

Looking at https://app.circleci.com/pipelines/github/falcosecurity/falco/1860/workflows/d1cb2a87-48d7-4c14-b02f-33576e82632d/jobs/16542, it seems like our CI does not have pkg-config; i think we should not rely on having it; i am going to try to use
find_package(gRPC REQUIRED)
and see if i can manage to make it work!

Question: does it worth upgrading gRPC to the newest version directly in this PR?

I think we might do that, because we will need to bump libs version in falco in any case.

[poiana]

@FedeDP: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
build-libs	e80943f	link	true	/test build-libs
build-libs-with-chisels	e80943f	link	true	/test build-libs-with-chisels
build-libs-bundled-deps	e80943f	link	true	/test build-libs-bundled-deps

Full PR test history. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[FedeDP]

Closing the PR: wrong solution proposed.