Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I was not able to override Content-Type header #856

Closed
PrettySolution opened this issue Apr 24, 2024 · 1 comment
Closed

I was not able to override Content-Type header #856

PrettySolution opened this issue Apr 24, 2024 · 1 comment
Labels
kind/bug Something isn't working
Milestone

Comments

@PrettySolution
Copy link

PrettySolution commented Apr 24, 2024

Describe the bug
I was not able to override Content-Type header as suggested in documentation for custom headers.

Technically, I should be able to override the Content-Type header by adding the key and a value in the webhook.customheaders map as the content type is also just a header but set before the custom ones.

How to reproduce it

install falco chart 4.2.4, enable falcosidekick and set up webhook connector
check logs in falco-falcosidekick Pod: Webhook - Unexpected Response (415)

set falcosidekick.enabled = true
set falcosidekick.config.webhook.address = http://xxx.yyy.194.126:10029/falco
set falcosidekick.config.webhook.method = POST
set falcosidekick.config.webhook.checkcert = false
set falcosidekick.config.webhook.customHeaders = content-type:application/json

Expected behaviour

content-type header strictly set.

  • Falco version:

4.2.4

  • Installation method:

Helm

@Issif
Copy link
Member

Issif commented Apr 26, 2024

The PR #857 fixes that issue.

@Issif Issif closed this as completed Apr 26, 2024
@github-project-automation github-project-automation bot moved this from To do to Done in Falcosidekick 2.x Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

2 participants