Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MessagePack serialization of HTTPError instances #333

Closed
kgriffs opened this issue Oct 9, 2014 · 3 comments
Closed

Add MessagePack serialization of HTTPError instances #333

kgriffs opened this issue Oct 9, 2014 · 3 comments

Comments

@kgriffs
Copy link
Member

kgriffs commented Oct 9, 2014

but... how to make the msgpack library an optional dependency?

@kgriffs kgriffs added this to the 0.2.1 milestone Oct 9, 2014
@rouge8
Copy link
Contributor

rouge8 commented Oct 9, 2014

but... how to make the msgpack library an optional dependency?

setuptools supports extras_require to declare optional dependencies, which can be installed like pip install falcon[extra-feature-name]. It's a bit annoying in tox though, the easiest way I've found is setting skipsdist = true and then adding -e{toxinidir}[feature1,feature2] to the deps section of the testenv.

@kgriffs
Copy link
Member Author

kgriffs commented Oct 9, 2014

Ah, good to know. Thanks!

@kgriffs kgriffs modified the milestones: 0.4, 0.3 Dec 1, 2014
@kgriffs kgriffs removed this from the 1.3 milestone Feb 17, 2016
@kgriffs kgriffs added this to the On Deck (Non-Breaking Changes) milestone May 3, 2016
@kgriffs kgriffs removed the interface label Oct 28, 2016
@kgriffs kgriffs added the needs contributor Comment on this issue if you'd like to volunteer to work on this. Thanks! label Apr 26, 2017
@kgriffs kgriffs modified the milestones: Version 2.0, Version 1.3 May 19, 2017
@kgriffs kgriffs removed the needs contributor Comment on this issue if you'd like to volunteer to work on this. Thanks! label May 19, 2017
@vytas7
Copy link
Member

vytas7 commented Feb 12, 2022

We don't want to special case MessagePack, but instead deliver the same functionality as part of #2023.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants