Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parquet file type in media #2335

Open
davetapley opened this issue Sep 19, 2024 · 4 comments
Open

Parquet file type in media #2335

davetapley opened this issue Sep 19, 2024 · 4 comments
Labels
enhancement needs contributor Comment on this issue if you'd like to volunteer to work on this. Thanks! proposal

Comments

@davetapley
Copy link
Contributor

davetapley commented Sep 19, 2024

Would a PR to add 'application/vnd.apache.parquet' here be welcome?

falcon/falcon/constants.py

Lines 137 to 145 in b29fd55

MEDIA_HTML = 'text/html; charset=utf-8'
MEDIA_TEXT = 'text/plain; charset=utf-8'
MEDIA_JPEG = 'image/jpeg'
MEDIA_PNG = 'image/png'
MEDIA_GIF = 'image/gif'
MEDIA_BMP = 'image/bmp'
DEFAULT_MEDIA_TYPE = MEDIA_JSON

@CaselIT
Copy link
Member

CaselIT commented Sep 20, 2024

Hi,

Probably not the most common file type, but I think it would be fine to have that constant.

Maybe we could add also csv? I'm not sure if there is standardized media type for it though

@vytas7
Copy link
Member

vytas7 commented Sep 20, 2024

Hm, I think it is maybe a bit too specific/niche? Because then it would feel logical to include many more media types like this.

Although it wouldn't hurt to add a constant or two, maybe we could instead start with an extension package, like falcon-parquet-handler? (That would include the said constant, and ParquetHandler.)

@vytas7
Copy link
Member

vytas7 commented Jan 10, 2025

On consideration, adding a couple more media types shouldn't really hurt.

@davetapley, we are happy to accept such a PR if you open it. While at it, you could add CSV according to RFC 4180 too.

There is also a related private mapping, constants._DEFAULT_STATIC_MEDIA_TYPES, for serving static files. We should add .parquet ➡️ MEDIA_PARQUET there.

@vytas7 vytas7 added the needs contributor Comment on this issue if you'd like to volunteer to work on this. Thanks! label Jan 10, 2025
@davetapley
Copy link
Contributor Author

@vytas7 great! I will say 'yes', but won't be soon. Will comment here when starting, others welcome until then!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement needs contributor Comment on this issue if you'd like to volunteer to work on this. Thanks! proposal
Projects
None yet
Development

No branches or pull requests

3 participants