-
-
Notifications
You must be signed in to change notification settings - Fork 930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(locale): and location to fr_SN #2533
Conversation
…faker into add-locale-senegal
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #2533 +/- ##
==========================================
- Coverage 99.58% 99.57% -0.01%
==========================================
Files 2787 2794 +7
Lines 249376 249473 +97
Branches 1084 1083 -1
==========================================
+ Hits 248333 248425 +92
- Misses 1015 1020 +5
Partials 28 28
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about location.state() does it make sense to use the regions for that?
https://en.wikipedia.org/wiki/Subdivisions_of_Senegal?wprov=sfti1#
Yes, that's a good idea, but should I remove them from the list of cities or not? |
In other locales where state names happen to duplicate city names, we normally leave them in. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Location module now seems well covered, could consider adding another PR with improved street names (otherwise will inherit from fr which might not be ideal).
Thanks for your contribution ❤️ . |
In this PR I add the most popular cities in Senegal as well as the zip code format.
https://en.wikipedia.org/wiki/List_of_cities_in_Senegal