refactor(person): remove duplicate title definitions #2523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewmayer
changed the title
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #2523 +/- ##
==========================================
- Coverage 99.59% 99.58% -0.01%
==========================================
Files 2823 2819 -4
Lines 255507 255135 -372
Branches 1105 1098 -7
==========================================
- Hits 254465 254075 -390
- Misses 1014 1032 +18
Partials 28 28
|
matthewmayer
added
c: refactor
ST-DDT
approved these changes
Nov 2, 2023
xDivisionByZerox
approved these changes
Nov 2, 2023
ST-DDT
changed the title
matthewmayer
added a commit
to matthewmayer/faker
that referenced
this pull request
Jan 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #2505
#2505 (comment)
If the job_title definitions etc are just exact copies of en, remove them and allow the standard fallback to en.