Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check capitisation of ex_MX/color/human #2841

Closed
ST-DDT opened this issue Apr 21, 2024 · 0 comments · Fixed by #3200
Closed

Check capitisation of ex_MX/color/human #2841

ST-DDT opened this issue Apr 21, 2024 · 0 comments · Fixed by #3200
Assignees
@ST-DDT
Labels
c: locale Permutes locale definitions help wanted Extra attention is needed m: color Something is referring to the color module p: 1-normal Nothing urgent
Milestone
vAnytime

Comments

@ST-DDT
Copy link
Member

ST-DDT commented Apr 21, 2024 •
edited
Loading

faker/src/locales/es_MX/color/human.ts

Line 2 in 9555be8

'Lima', 

          Seems random that some colors are capitalised here?

Originally posted by @matthewmayer in #2837 (comment)
@ST-DDT ST-DDT mentioned this issue Apr 21, 2024
Merged
@xDivisionByZerox xDivisionByZerox added help wanted Extra attention is needed s: awaiting more info Additional information are requested c: locale Permutes locale definitions m: color Something is referring to the color module labels Apr 23, 2024
@ST-DDT ST-DDT mentioned this issue Oct 20, 2024
Merged
@ST-DDT ST-DDT self-assigned this Oct 20, 2024
@ST-DDT ST-DDT added this to the vAnytime milestone Oct 20, 2024
@ST-DDT ST-DDT added p: 1-normal Nothing urgent and removed s: awaiting more info Additional information are requested labels Oct 20, 2024
@rasputino rasputino mentioned this issue Oct 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ST-DDT ST-DDT

Labels
c: locale Permutes locale definitions help wanted Extra attention is needed m: color Something is referring to the color module p: 1-normal Nothing urgent
Projects
None yet
Milestone
vAnytime
Development

Successfully merging a pull request may close this issue.

refactor(locale): lowercase Mexican color names faker-js/faker
2 participants
@ST-DDT @xDivisionByZerox