Remove defaults from image module

[ST-DDT]

Clear and concise description of the problem

Currently most of the image module's functions have defaults for their options.
These defaults originate from the legacy faker project and are arbitrarily chosen.

Suggested solution

Remove the defaults and make them random to increase the variety of our generated data.
The options should remain optional.

Alternative

Keep it as is.

Additional context

Related:

• feat(image): add image dataUri with base64 #2273 (comment) (new type option)
• faker.image.dataUri is not random #2307 (limited to dataUri)

[olrtg]

I would like to work on this later this day!

[ST-DDT]

I would like to work on this later this day!

Thanks. Please note that this is schedulled for v9.0 and thus might take a while before it can be merged (At least 2 weeks).

[olrtg]

Sure! no worries. And please note that I may not be able to work on this today 😆 but will try!

[olrtg]

Hey! two questions. What about urlLoremFlickr and urlPicsumPhotos? Both have a default width/height also. Should I randomize those two too?

And the other question is, what method should I use to randomize those values? Do you want to use arrayElements? What would be the set of values? 🤔

[ST-DDT]

What about urlLoremFlickr and urlPicsumPhotos? Both have a default width/height also. Should I randomize those two too?

Yes. Please.

And the other question is, what method should I use to randomize those values? Do you want to use arrayElements? What would be the set of values? 🤔

I would probably go for faker.number.int between 1px and 4k. We can discuss the exact values when we have the PR.

[olrtg]

Great! thanks for the quick reply. Will work on that!