Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accept dates as params for Date methods #198

Closed
pkuczynski opened this issue Jan 17, 2022 · 1 comment · Fixed by #200
Closed

Accept dates as params for Date methods #198

pkuczynski opened this issue Jan 17, 2022 · 1 comment · Fixed by #200
Assignees
@pkuczynski
Labels
c: bug Something isn't working p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Milestone
v6.1 - First bugf...

Comments

@pkuczynski
Copy link
Member

pkuczynski commented Jan 17, 2022 •
edited
Loading

Describe the bug

Old faker used to support dates for functions like faker.date.past or faker.date.between. New types do not allow such calls.

Reproduction

const baseDate = new Date()

faker.past(1, baseDate)

Additional Info

No response
@pkuczynski pkuczynski added the s: pending triage Pending Triage label Jan 17, 2022
@pkuczynski pkuczynski mentioned this issue Jan 17, 2022
Merged
@pkuczynski pkuczynski changed the title Accept dates as params for Date methods fix: accept dates as params for Date methods Jan 17, 2022
@pkuczynski pkuczynski changed the title fix: accept dates as params for Date methods Accept dates as params for Date methods Jan 17, 2022
@Shinigami92 Shinigami92 added the c: bug Something isn't working label Jan 17, 2022
@Shinigami92 Shinigami92 moved this to In Progress in Faker Roadmap Jan 17, 2022
@Shinigami92 Shinigami92 added this to the v6.1.0 milestone Jan 17, 2022
@github-actions github-actions bot removed the s: pending triage Pending Triage label Jan 17, 2022
@damienwebdev damienwebdev mentioned this issue Jan 26, 2022
Closed
@ST-DDT ST-DDT added p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug labels Mar 18, 2022
Repository owner moved this from In Progress to Done in Faker Roadmap Mar 24, 2022
@ST-DDT ST-DDT removed this from Faker Roadmap Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pkuczynski pkuczynski

Labels
c: bug Something isn't working p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
None yet
Milestone
v6.1 - First bugfixes
Development

Successfully merging a pull request may close this issue.

fix: accept dates as params for Date methods pkuczynski/faker
4 participants
@pkuczynski @ST-DDT @Shinigami92 and others