github-actions bot also triggers when build step failed

[Shinigami92]

Pre-Checks

• Follow our Code of Conduct.
• Read the Contributing Guidelines.
• Read the docs.
• Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
• Make sure this is a Faker issue and not related to a combination with another package.
• Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
• The provided reproduction is a minimal reproducible example of the bug.
• I am willing to provide a PR.

Describe the bug

This is an infra bug in our CI

The github-actions bot also triggers when build step failed
Then it suggest to run pnpm run generate:locales, pnpm run generate:api-docs, and pnpm run test -u
But these are totally wrong suggestions as the build step already failed

I see two solutions:

1. Do not print the github-actions bot when the build or anything before that already failed (my preferred solution)
2. Listing all comments that needs to be done to fix the CI (this could get very spammy and unnecessary verbose)

Minimal reproduction code

No response

Additional Context

Environment Info

-

Which module system do you use?

• CJS
• ESM

Used Package Manager

pnpm

[xDivisionByZerox]

This will be solved by #1846 as well

[ST-DDT]

This will be solved by #1846 as well

🤔 We either have to change the wording to not explicitly refer to uncommitted changes
or have to change the conditions for firing the message.

[xDivisionByZerox]

@ST-DDT can this be considered fixed and closed?

[ST-DDT]

No, the message still refers to uncommited changes, but also triggers for test failures and other stuff IIRC.
(Also the message only triggers for members and not external contributors.)