location.zipCodeByState should throw for unknown states

[ST-DDT]

Clear and concise description of the problem

Currently, if the given state is not known, then a random zip code is returned.
Usually, if I pass a value to a method, then I expect it to use it and tell me if the value is wrong.

Suggested solution

Throw if there is no data for that state.

Alternative

Keep the method as is.

Additional context

https://next.fakerjs.dev/api/location.html#zipcodebystate

[ST-DDT]

Team decision

If the user explicitly calls zipCodeByState, then it should make sure that the state is actually valid.
-> throw error if the state is unknown.

[Shinigami92]

Team decision

If the user explicitly calls zipCodeByState, then it should make sure that the state is actually valid. -> throw error if the state is unknown.

Sounds legit to me 👍

---

I move this to v8 milestone so we do not put more and more into v8.0
It's not blocked and if someone works on it, go for it, but if not, it can be a bug-fix later in v8.x

[ST-DDT]

I move this to v8 milestone so we do not put more and more into v8.0
It's not blocked and if someone works on it, go for it, but if not, it can be a bug-fix later in v8.x

It would change documented api, so I consider this breaking:

If a locale does not have a postcode_by_state definition, a random zip code is generated according to the locale's zip format.

[ST-DDT]

Pinging @0916dhkim to leave a comment hete so I can assign them to this issue for #1760 .

[0916dhkim]

👍

[xDivisionByZerox]

If this is a breaking change, this needs to be put into the8.0 milestone no?

[ST-DDT]

Team Decision

• We want to merge zipCode and zipCodeByState into a single method instead (Check modules and methods regarding their name and location #1346 (comment))
• It will still throw an error if the state doesn't have a config.