-
-
Notifications
You must be signed in to change notification settings - Fork 930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate random symbol (eg: ! _ #) #1711
Comments
What is the difference to faker.string.special? Should we rename that method? |
No difference at all! It's actually what I was looking for, but could not find it... It's also on the By the way, why method generating UTF-16 is called |
We can rename it without making a breaking change, as the current released alpha is not intended to be "stable" I would be ok with renaming it, but should it be symbol or symbols? it can generate more then one char 🤔 |
I was thinking the same, but if you look at |
I can provide a PR if everybody agrees... |
I'm fine with renaming. The jsdoc should contain both the symbol and special characters terms. |
I would also keep it as |
FWIW i think the documentation should list out what "special" characters this pulls from. Only simple punctation marks? Spaces? Dingbats and emojis? Accented letters? The list seems short enough you could just list them explicitly.
|
@pkuczynski Are you still interested in providing a PR for this Issue (or even already working on it)? Since this is blocking for v8 I'd like to not keep this around any longer. |
Go ahead. I am still tied with my personal life :( |
Clear and concise description of the problem
Provide a method which would generate random symbol (non alphanumeric character), for example
!#_-/\.$
.Suggested solution
Alternative
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: