Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide TypeScript support for locales #167

Closed
Shinigami92 opened this issue Jan 16, 2022 · 0 comments · Fixed by #169
Closed

Provide TypeScript support for locales #167

Shinigami92 opened this issue Jan 16, 2022 · 0 comments · Fixed by #169
Assignees
@Shinigami92
Labels
c: bug Something isn't working
Milestone
v6.0 - Ensure Pro...

Comments

@Shinigami92
Copy link
Member

Describe the bug

It is already possible to import locales via e.g.: import en from '@faker-js/faker/lib/locales/en'

This was also documented in the old docs and is the wanted behaviour to import additional locales.
In the old way it was just faker/locales/en. But now were we're planning to bundle cjs, esm and umd anyways, we could look if we want to provide it differential as before.

Reproduction

Go to index.ts in https://typescript-wsqtmx.stackblitz.io and see

image

Additional Info

Version: v6.0.0-alpha.3
@Shinigami92 Shinigami92 added s: pending triage Pending Triage c: bug Something isn't working labels Jan 16, 2022
@github-actions github-actions bot removed the s: pending triage Pending Triage label Jan 16, 2022
@Shinigami92 Shinigami92 linked a pull request Jan 16, 2022 that will close this issue
fix: ts support for locales #169
Merged
@Shinigami92 Shinigami92 self-assigned this Jan 16, 2022
@prisis prisis added this to the v6.0.0 milestone Jan 16, 2022
@prisis prisis moved this to In Progress in Faker Roadmap Jan 16, 2022
@Shinigami92 Shinigami92 moved this from In Progress to Awaiting Review in Faker Roadmap Jan 16, 2022
Repository owner moved this from Awaiting Review to Done in Faker Roadmap Jan 19, 2022
@ST-DDT ST-DDT removed this from Faker Roadmap Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Shinigami92 Shinigami92

Labels
c: bug Something isn't working
Projects
None yet
Milestone
v6.0 - Ensure Project Foundation
Development

Successfully merging a pull request may close this issue.

fix: ts support for locales faker-js/faker
2 participants
@prisis @Shinigami92