Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename bannedChars and bannedDigits in string module #1465

Closed
Shinigami92 opened this issue Oct 17, 2022 · 3 comments · Fixed by #1551
Closed

Rename bannedChars and bannedDigits in string module #1465

Shinigami92 opened this issue Oct 17, 2022 · 3 comments · Fixed by #1551
Assignees
@ejcheng
Labels
c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs m: string Something is referring to the string module s: accepted Accepted feature / Confirmed bug
Milestone
v8.0 - Module Re-...

Comments

@Shinigami92
Copy link
Member

Extracted out of #1155 (comment)

The parameter names bannedChars and bannedDigits could be unified to e.g.:

  • except
  • without
  • exclude

This needs to be done in v8.0 so we do not make breaking changes later on
@Shinigami92 Shinigami92 added s: needs decision Needs team/maintainer decision c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs labels Oct 17, 2022
@Shinigami92 Shinigami92 mentioned this issue Oct 17, 2022
Merged
@Shinigami92 Shinigami92 moved this to Todo in Faker Roadmap Oct 17, 2022
@Shinigami92 Shinigami92 added the m: string Something is referring to the string module label Oct 17, 2022
@ST-DDT
Copy link
Member

ST-DDT commented Nov 10, 2022

Team decision

  • exclude

@ST-DDT ST-DDT added s: accepted Accepted feature / Confirmed bug and removed s: needs decision Needs team/maintainer decision labels Nov 10, 2022
@ejcheng
Copy link
Member

ejcheng commented Nov 10, 2022

I can take this one

@ejcheng ejcheng self-assigned this Nov 10, 2022
@ejcheng ejcheng moved this from Todo to Awaiting Review in Faker Roadmap Nov 12, 2022
@ejcheng ejcheng mentioned this issue Nov 12, 2022
Merged
@matthewmayer
Copy link
Contributor

as this is a breaking change should also be added to the migration guide #1518

Repository owner moved this from Awaiting Review to Done in Faker Roadmap Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ejcheng ejcheng

Labels
c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs m: string Something is referring to the string module s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Faker Roadmap
Status: Done
Milestone
v8.0 - Module Re-Shuffling
Development

Successfully merging a pull request may close this issue.

refactor(string): rename params faker-js/faker
4 participants
@matthewmayer @ST-DDT @Shinigami92 @ejcheng