Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try to eliminate circular dependencies in modules #1347

Closed
ST-DDT opened this issue Sep 6, 2022 · 3 comments
Closed

Try to eliminate circular dependencies in modules #1347

ST-DDT opened this issue Sep 6, 2022 · 3 comments
Labels
breaking change Cannot be merged when next version is not a major release c: docs Improvements or additions to documentation c: feature Request for new feature c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs p: 1-normal Nothing urgent
Milestone
v8.x

Comments

@ST-DDT
Copy link
Member

ST-DDT commented Sep 6, 2022

Clear and concise description of the problem

There might be circular dependencies in our modules that would impede our attempts to improve tree shaking capabilities.

Suggested solution

  • Write a repeatable script that fetches the inter module dependencies and generates a visual graph.
  • Try to eliminate circular dependencies between modules

Alternative

No response

Additional context

No response
@ST-DDT ST-DDT added c: docs Improvements or additions to documentation c: feature Request for new feature s: on hold Blocked by something or frozen to avoid conflicts p: 1-normal Nothing urgent c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs breaking change Cannot be merged when next version is not a major release labels Sep 6, 2022
@ST-DDT ST-DDT added this to the v8.0 - Module Re-Shuffling milestone Sep 6, 2022
@ST-DDT
Copy link
Member Author

ST-DDT commented Sep 6, 2022

See also #1346

@ST-DDT ST-DDT moved this to Todo in Faker Roadmap Oct 13, 2022
@ST-DDT
Copy link
Member Author

ST-DDT commented Nov 21, 2022 •
edited
Loading

The/A separate script should also run on the locale definitions.

Ref: #1585

@ST-DDT ST-DDT removed the s: on hold Blocked by something or frozen to avoid conflicts label Jan 26, 2023
@ST-DDT
Copy link
Member Author

ST-DDT commented Oct 10, 2023

This should be obsolete in v9 anyway.

@ST-DDT ST-DDT closed this as not planned Won't fix, can't repro, duplicate, stale Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking change Cannot be merged when next version is not a major release c: docs Improvements or additions to documentation c: feature Request for new feature c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs p: 1-normal Nothing urgent
Projects
No open projects
Faker Roadmap
Status: Todo
Milestone
v8.x
Development

No branches or pull requests
1 participant
@ST-DDT