Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Number methods to own module #1342

Closed
ST-DDT opened this issue Sep 6, 2022 · 2 comments · Fixed by #1122
Closed

Move Number methods to own module #1342

ST-DDT opened this issue Sep 6, 2022 · 2 comments · Fixed by #1122
Assignees
@xDivisionByZerox
Labels
breaking change Cannot be merged when next version is not a major release c: feature Request for new feature c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs m: datatype Something is referring to the datatype module p: 1-normal Nothing urgent
Milestone
v8.0 - Module Re-...

Comments

@ST-DDT
Copy link
Member

ST-DDT commented Sep 6, 2022

Clear and concise description of the problem

Currently the number methods are spread in multiple modules and it isn't easy to guess them correctly.

Suggested solution

  • All random number methods should be in their own module
  • The old methods are preserved for a full major version (deprecated)

Alternative

No response

Additional context

No response
@ST-DDT ST-DDT added c: feature Request for new feature s: on hold Blocked by something or frozen to avoid conflicts p: 1-normal Nothing urgent c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs breaking change Cannot be merged when next version is not a major release m: datatype Something is referring to the datatype module labels Sep 6, 2022
@ST-DDT ST-DDT added this to the v8.0 - Module Re-Shuffling milestone Sep 6, 2022
@ST-DDT ST-DDT moved this to In Progress in Faker Roadmap Sep 6, 2022
@ST-DDT
Copy link
Member Author

ST-DDT commented Sep 6, 2022

See also #805

@ST-DDT ST-DDT linked a pull request Sep 6, 2022 that will close this issue
feat(number): move methods to new module #1122
Merged
@ST-DDT
Copy link
Member Author

ST-DDT commented Sep 6, 2022

Blocked by #932 / #1291

@ST-DDT ST-DDT mentioned this issue Sep 6, 2022
Closed
@ST-DDT ST-DDT removed the s: on hold Blocked by something or frozen to avoid conflicts label Oct 12, 2022
@ST-DDT ST-DDT moved this from In Progress to Awaiting Review in Faker Roadmap Oct 12, 2022
Repository owner moved this from Awaiting Review to Done in Faker Roadmap Nov 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xDivisionByZerox xDivisionByZerox

Labels
breaking change Cannot be merged when next version is not a major release c: feature Request for new feature c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs m: datatype Something is referring to the datatype module p: 1-normal Nothing urgent
Projects
No open projects
Faker Roadmap
Status: Done
Milestone
v8.0 - Module Re-Shuffling
Development

Successfully merging a pull request may close this issue.

feat(number): move methods to new module faker-js/faker
2 participants
@ST-DDT @xDivisionByZerox