Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 7.3.0: faker.name.fullName is not a function #1208

Closed
jonathanlinat opened this issue Jul 29, 2022 · 8 comments
Closed

Version 7.3.0: faker.name.fullName is not a function #1208

jonathanlinat opened this issue Jul 29, 2022 · 8 comments
Labels
c: bug Something isn't working has workaround Workaround provided or linked m: person Something is referring to the person module

Comments

@jonathanlinat
Copy link

jonathanlinat commented Jul 29, 2022

Describe the bug

When I try to use faker.name.fullName(), my app crashes because that particular function doesn't exist.

image

image

Reproduction

  • Install @faker-js/faker version 7.3.0 using the command npm install -D @faker-js/[email protected]
  • Import the library: const { faker } = require('@faker-js/faker')
  • Make use of faker.name.fullName() function

Additional Info

The function is not present in the compiled bundle somehow..?

image

The documentation has a reference to that particular function: https://fakerjs.dev/api/name.html#fullName

The source code also has a reference to it: https://github.com/faker-js/faker/blob/main/src/modules/name/index.ts#L184

@jonathanlinat jonathanlinat added the s: pending triage Pending Triage label Jul 29, 2022
@jonathanlinat jonathanlinat changed the title @faker-js v7.3.0: faker.name.fullName is not a function Version 7.3.0: faker.name.fullName is not a function Jul 29, 2022
@xDivisionByZerox
Copy link
Member

xDivisionByZerox commented Jul 29, 2022

I'm very sure this feature is not released yet. faker.name.findName() was renamed to faker.name.fullName in #1127 on the 19th of this month. But faker v7.3.0 was released on the 18th. So I'm there sure this feature didn't make it, but will be released in v7.4.

For now you can still use faker.name.findName(), should be the same implementation.

@xDivisionByZerox xDivisionByZerox added c: bug Something isn't working has workaround Workaround provided or linked m: person Something is referring to the person module and removed s: pending triage Pending Triage labels Jul 29, 2022
@jonathanlinat
Copy link
Author

Perfect. Thanks.

@xDivisionByZerox
Copy link
Member

May I ask: How did you get to know of fullName()? Was your IDE suggesting it via autocomplete?

@jonathanlinat
Copy link
Author

jonathanlinat commented Jul 29, 2022

Sure. The current documentation references that specific function. There seems to be a discrepancy between the generated version of the library and its documentation.

Is possible that the problem is located in the CI pipeline?

@xDivisionByZerox
Copy link
Member

The current documentation references that specific function.

Oh wow. Thank you, I will discuss this with the maintainers/members to pinpoint the problem.

@jonathanlinat
Copy link
Author

You're welcome. 👍🏻

@xDivisionByZerox
Copy link
Member

I will close this due to the circumstances. If you (or any other person) are against that, feel free to reopen.

@astanciu
Copy link

astanciu commented Aug 3, 2022

Ran into the same issue. faker.company.name is another example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: bug Something isn't working has workaround Workaround provided or linked m: person Something is referring to the person module
Projects
None yet
Development

No branches or pull requests

3 participants