Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Username length limitation #155

Open
tamas6 opened this issue Jun 5, 2023 · 3 comments
Open

Username length limitation #155

tamas6 opened this issue Jun 5, 2023 · 3 comments

Comments

@tamas6
Copy link

tamas6 commented Jun 5, 2023

          @tamas6 move this issue to fdp-storage then please.

Originally posted by @crtahlin in fairDataSociety/fdp-create-account#243 (comment)

@tamas6 tamas6 changed the title @tamas6 move this issue to fdp-storage then please. Username length limitation Jun 5, 2023
@tamas6
Copy link
Author

tamas6 commented Jun 5, 2023

I was unable to create ‘accountSep’
Due to “Invalid username” error

@.staging.
🤷🏻‍♂️

@IgorShadurin
Copy link
Contributor

IgorShadurin commented Oct 20, 2023

The error comes from fdp-contracts

assert(isUsername(username), 'Username is not valid.')

and then handled in fdp-create-account
https://github.com/fairDataSociety/fdp-create-account/blob/ac19102228038d64afc72e1881210e93695c7e62/src/pages/register/username-password.tsx#L98

@IgorShadurin IgorShadurin transferred this issue from fairDataSociety/fdp-storage Oct 20, 2023
@tamas6
Copy link
Author

tamas6 commented Oct 20, 2023

First goal is to inform user the password is invalid due to not knowing the parameters of a correct password.
So let's show it them under the field. "Invalid Password" in red is now a bit a scary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants