Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating a bag from a remote file manifest raises an exception #15

Closed
NickolausDS opened this issue Dec 12, 2017 · 2 comments
Closed

Creating a bag from a remote file manifest raises an exception #15

NickolausDS opened this issue Dec 12, 2017 · 2 comments

Comments

@NickolausDS
Copy link
Contributor

When creating a bag with the following command:

$ bdbag bag/ --remote-file-manifest manifest.json

An error is raised:

RuntimeError: Expected the same number of files for each checksum

Details about the above command:

  • Run with Bagit version bagit==1.6.2
  • Run with BDBag version bdbag==1.1.1
  • bag/ in the command above is an empty directory
  • manifest.json corresponds to the example in the docs

This didn't seem to happen on previous versions. Before, it allowed me to create an 'empty' bdbag with a fetch file that could be used to pull down the remote files and validate them.

@NickolausDS NickolausDS changed the title Creating bag from remote file manifests raises an exception Creating a bag from remote file manifests raises an exception Dec 12, 2017
@NickolausDS NickolausDS changed the title Creating a bag from remote file manifests raises an exception Creating a bag from a remote file manifest raises an exception Dec 12, 2017
@mikedarcy
Copy link
Collaborator

Unfortunately, this is an issue with bagit-1.6.x and some new error checking logic which basically is prohibiting the bagging of an empty directory. I can reproduce this with just bagit ./bag/ on an empty directory. This worked in bagit-1.5.4 and I think needs to continue to work. There is a pretty easy one line fix for this in bagit.py so I will file a PR with bagit and see what they have to say.

@mikedarcy
Copy link
Collaborator

mikedarcy commented Dec 12, 2017

Filed a PR for bagit: LibraryOfCongress/bagit-python#100

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants