Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate version specific scripts p2 #288

Merged
merged 3 commits into from
Mar 13, 2019

Conversation

gyermolenko
Copy link
Contributor

In continuation to #287

With this PR all 4 example scripts with metaclass usage have two versions.

What I found out is that:

  • blackboard outputs are random and can't be tested as is
  • flyweight almost certainly can be refined ( see also )

Future plans/ideas:

  • add diff compare of __py2/__py3 files to CI so they be updated together
  • add tox config to make linting/tests with different py versions easier

@codecov-io
Copy link

codecov-io commented Mar 9, 2019

Codecov Report

Merging #288 into master will decrease coverage by 4.91%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #288      +/-   ##
==========================================
- Coverage   66.85%   61.94%   -4.92%     
==========================================
  Files          58       59       +1     
  Lines        2091     2181      +90     
==========================================
- Hits         1398     1351      -47     
- Misses        693      830     +137
Impacted Files Coverage Δ
patterns/other/blackboard__py2.py 0% <ø> (ø)
patterns/structural/flyweight__py2.py 0% <0%> (ø)
patterns/other/blackboard__py3.py 0% <0%> (ø)
patterns/structural/flyweight__py3.py 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 423fe9d...c1ab03c. Read the comment docs.

@faif faif merged commit 6726564 into faif:master Mar 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants