Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix plot widget drag and drop bug (Issue #716) #717

Merged
merged 1 commit into from
Aug 10, 2022

Conversation

Bartimaeus-
Copy link
Contributor

  • Plot widgets were not clearing their drag and drop state if a drag event left the widget, causing mouse events to not be handled properly if the drop event happened in another plot widget
  • Added event handlers for drag leave event

(This was actually a pain to debug at first because it seemed like it was only impacting the first plot widget that existed, but it was just unfortunate that I was really repeatably dragging across the same widget)

@facontidavide facontidavide merged commit 8366006 into facontidavide:main Aug 10, 2022
@facontidavide
Copy link
Owner

facontidavide commented Aug 10, 2022

fantastic, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants