Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Statistics dialog improvements and bug fixes #702

Merged
merged 7 commits into from
Jul 25, 2022

Conversation

Bartimaeus-
Copy link
Contributor

Changes and bug fixes to the statistics dialog window

Improvements:

  • Statistics can now be calculated from the visible range or by the full data range (previously only visible range)
    image

  • Statistics window title now includes the title from the plot

  • Made the dialog window stay on top of the PlotJuggler window but not on top of other programs. The statistics dialogs will minimize/restore with the main PJ window. Previously the statistics dialog windows would stay on top of all windows

  • Made the table sortable by column (click on the header item to sort by that column) (Edit: disabled this as there are bugs. earlier commit kept as it set the styling for the arrows)

Bug fixes:

  • Fix bug where statistics would only get updated for the plot with the mouse over it when zooming while plot zooms were linked
  • Fix bug where the statistics weren't updated when the zoom reset button was pressed
  • Fix bug where series weren't removed from the statistics dialog right away after a curve was removed from the plot

@Bartimaeus-
Copy link
Contributor Author

I'm not able to test the "full range" mode with a streaming timeseries (tested with csv files). I'm not sure if it will update as new data points are added to the series. Help with testing this would be appreciated

@facontidavide facontidavide merged commit 1b23107 into facontidavide:main Jul 25, 2022
facontidavide added a commit that referenced this pull request Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants