Fix start/end time bug in CSV Exporter #682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changed the behavior so that the buttons remain clickable and they will uncheck the first/last checkboxes when clicked. This should avoid the potential annoyance of having to uncheck the first/last checkboxes when trying to manually set the start and end times. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bug with the csv publisher where clicking buttonGetStart or buttonGetEnd buttons would override the checkBoxFirst/checkBoxLast selections
Fixed by enabling/disabling the buttons when the checkboxes are toggledEdit: fixed by unchecking the first/last checkboxes when the button is pressed. This seems less of an annoyance where a user may move the cursor and want to set the time and not notice that the first/last checkbox is checked