Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the issue raised here: #289
This does 3 main things:
ament_package()
at the end of the CMakeLists.txt to make it so that the ros2 package index can findplotjuggler
lib/plotjuggler/
instead ofbin
so thatros2 run
can find them.$CATKIN_WS/install/plotjuggler/lib/plotjuggler/
) so that they can be found by PlotJuggler. Ideally, they would be in the standard library location ($CATKIN_WS/install/plotjuggler/lib/
) but then they cannot be found by PlotJuggler because it only looks in its current directory and in a system install dir.tree $CATKIN_WS/install/plotjuggler
should now produce the (mostly) standard directory structure: