Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

research: alternative to string for decimal conversion #392

Open
DaveSkender opened this issue Aug 11, 2024 · 1 comment
Open

research: alternative to string for decimal conversion #392

DaveSkender opened this issue Aug 11, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@DaveSkender
Copy link
Member

DaveSkender commented Aug 11, 2024

I had a quick test. And this way has max 3x performance gain!

    if cs_decimal is not None:
        return CsDecimal.ToDouble(cs_decimal)

But few tests fail due to precision problem

Originally posted by @LeeDongGeon1996 in #386 (comment)

@DaveSkender
Copy link
Member Author

This is worth exploring IMO given the risk vs. reward tradeoff; though, we should check it out to see if precision loss from converting through double to decimal is significant compared to current string based conversion. See prior discussion on Precisions v. Performance of decimal vs double.

@DaveSkender DaveSkender added question Further information is requested enhancement New feature or request and removed enhancement New feature or request question Further information is requested labels Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: 💡 Triage
Development

No branches or pull requests

1 participant