Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block PHPUnit colors in CLI instead of requiring to disable it in XML config #8

Closed
Jean85 opened this issue Aug 25, 2015 · 3 comments
Closed
Assignees

Comments

@Jean85
Copy link
Member

Jean85 commented Aug 25, 2015

I've just discovered that you can disable PHPUnit colors in CLI with:

--colors=never

I would like to enforce it on every PHPUnit process that Paraunit launches, to avoid parsing problems and to remove from requirements the disable of colors from the XML config file.

BTW, I need first to investigate from which version of PHPUnit this option is supported... I think I'll open an issue on PHPUnit because this option is undocumented.

@Jean85 Jean85 self-assigned this Aug 25, 2015
@Jean85
Copy link
Member Author

Jean85 commented Aug 26, 2015

Ok, I've discovered that this CLI feature is present from PHPUnit 4.6.0: sebastianbergmann/phpunit#1527

This Paraunit fix then will bring up the requirements to that version. I think it will be fair, since the minor versions of PHPUnit shouldn't have BC problems, and they're dropped from support immediately when a newer minor is released.

@ranpafin
Copy link
Collaborator

@Jean85 As a side note i noticed a few posts of Bergman in which he remarked some sort of 'project policy' to keep command line argument to a minimum. The idea was to move everything (that can be moved) to the .xml config file.

This feature seem to contradict such policy but i wouldn’t count too much much on his lifespan :)

@Jean85
Copy link
Member Author

Jean85 commented Aug 30, 2015

I saw that too, but it was in a previous pull request. Instead, this feature is an extension of the --colors option, that is present since 3.0, I think. So, it's safe to assume that's here to stay ;)

@Jean85 Jean85 closed this as completed in 51acbca Sep 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants