doctrine/dbal ^4.0.0 #84
Conversation
|
@Jean85 could you please take a look? |
There was a problem hiding this comment.
Thank you for this PR, I'll try to work with you to make viable and release it!
I agree that this will require a new major, I'll later change it to target a new major branch; in the meantime, I'll backport whatever makes sense (like the Psalm fixes) from this PR to the existing major.
I've left some comments; also, for Infection, to fix it you have to add a test that would fail when editing the code in the mutated cases that it highlights.
|
|
||
| - php-version: "8.3" | ||
| mysql-version: "5.7" | ||
| custom-entrypoint: ~ | ||
| job: Tests | ||
| - php-version: "8.2" | ||
|
|
||
| - php-version: "8.3" | ||
| mysql-version: "5.7" | ||
| job: Tests |
There was a problem hiding this comment.
Here you created a duplicate. You should test MySQL 8 against PHP 8.1
| @@ -109,7 +111,7 @@ jobs: | |||
| command: vendor/bin/php-cs-fixer fix --dry-run --ansi --verbose | |||
| - name: Psalm | |||
| commandName: Run Psalm analysis | |||
| command: vendor/bin/php-cs-fixer fix --dry-run --ansi --verbose | |||
| command: vendor/bin/psalm --show-info=true | |||
composer.json
Outdated
| "php": "^7.4 || ^8.0", | ||
| "doctrine/dbal": "^3.6.0" | ||
| "php": "^8.1", | ||
| "doctrine/common": "^3.4", |
There was a problem hiding this comment.
It was required because some class was missing from common namespace
docker/Dockerfile
Outdated
| # zsh / OhMyZsh | ||
| RUN apk --no-cache add git zsh | ||
|
|
||
| ARG COMPOSER_VERSION=2.5.5 | ||
| RUN curl -sS https://getcomposer.org/installer | php -- \ | ||
| --install-dir=/usr/local/bin --filename=composer --version=$COMPOSER_VERSION | ||
|
|
||
| USER facile | ||
| RUN sh -c "$(curl -fsSLv https://raw.githubusercontent.com/ohmyzsh/ohmyzsh/master/tools/install.sh)" |
There was a problem hiding this comment.
Please do not remove this custom shell.
|
I've backported some of your fixes with #84, and retargeted this PR to the new |
|
@Jean85 Thanks for help and so fast response! This will allow use to use ORM4 and Symfony 7 ❤️ |
|
Thank you for the help! Also, keep in mind that ORM 3 is still usable with DBAL 3, you're not forced to upgrade them together, you can split the upgrade. |
This should be a major version because:
dbal is using union type which are from PHP8.0
dbal require php8.1
fixed also psalm in ci (it was not running)
increased mutation score