Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a constraint layer #1053

Merged
merged 13 commits into from
Feb 26, 2021
Merged

Add a constraint layer #1053

merged 13 commits into from
Feb 26, 2021

Conversation

jrapin
Copy link
Contributor

@jrapin jrapin commented Feb 17, 2021 •
edited
Loading

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Motivation and Context / Related issue

How Has This Been Tested (if it applies)

Checklist

  • The documentation is up-to-date with the changes I made.
  • I have read the CONTRIBUTING document and completed the CLA (see CLA).
  • All tests passed, and additional code has been covered with new tests.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Feb 17, 2021
@jrapin jrapin self-assigned this Feb 17, 2021
@jrapin jrapin requested a review from teytaud February 17, 2021 21:20
@jrapin jrapin changed the title [WIP] Add a constraint layer Add a constraint layer Feb 17, 2021
@jrapin
Copy link
Contributor Author

jrapin commented Feb 17, 2021

Drawback: the suboptimizer is not aware of the "scale" of the optimization that is going on, so it may completely override the main optimization :s

@jrapin jrapin merged commit 124f8cb into facebookresearch:master Feb 26, 2021
@jrapin jrapin deleted the constraint_layer branch February 26, 2021 12:23
@dependabot dependabot bot mentioned this pull request Mar 17, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teytaud teytaud Awaiting requested review from teytaud

Assignees

@jrapin jrapin

Labels
CLA Signed Do not delete this pull request or issue due to inactivity. Difficulty: Medium Priority: Critical
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jrapin @facebook-github-bot