-
Notifications
You must be signed in to change notification settings - Fork 442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build failed: could not find from_json() method in T's namespace #16
Comments
mosra/magnum-plugins#54 says that the issue was fixed by updating to a newer version. Can you try updating the magnum-plugins submodule (you may also need to update the magnum and corrade submodues) to confirm the fix? |
@erikwijmans Well, I tried, but it did not help. The reason is that the commit which fixes this issue in magnum-plugins repo is more recent than latest releases in both magnum and corrade. In any case, even if that error disappears - another ones occur. What really helped to fix my issue is to make same changes as in commit that fixes mosra/magnum-plugins#54 , so I just replaced my
right after
in |
Glad you found a fix, we will update magnum in the not so distant future. Keeping this open until then. |
Came here to report the same issue. We should really freeze the version/commit-id of magnum we use. |
Even after ^^this fix by @titardrew, I am seeing the following error with viewer:
Seems to be dying here: |
We have frozen the version/commit-id of magnum. This appears to be an update to MacOS or clang that is causing this. |
I have now run into this issue also (going to update Magnum, just need to fix a few compile errors). I do not get the same issue as you @dhruvbatra, can you try a clean build (do CC: @msavva |
Clean build, seeing same error. |
This warning is unrelated (it just checked if the app was Retina-enabled and discovered it's not, which is not a critical problem). The "Illegal instruction" seems to be a mismatch between macOS versions it was compiled for and used on? Can you get a backtrace? |
I now also encountered the above build error after a MacOS and Xcode update. Build error is resolved using @titardrew 's fix but then I also encounter the
|
I believe this issue should be fixed. If so, please close @titardrew |
@dhruvbatra, sure. Thanks for this fix! |
Build fails on:
OSX 10.14.3
gcc/g++ 4.2.1
andclang/clang++ 10.0.1
Steps to reproduce
python setup.py install
Observed Results
It seems like it is known issue of MagnumPlugins (its TinyGltf's json dependency) e.g.:
mosra/magnum-plugins#54
nlohmann/json#539
nlohmann/json#1140
nlohmann/json#917
The text was updated successfully, but these errors were encountered: