Add error for overflowing nbits during PQ construction #3833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D62153881 |
…rch#3833) Summary: Pull Request resolved: facebookresearch#3833 size_t expands to unsigned long int, so any left shift more than 31 means ksub overflows. So, we can add a check right before it is constructed in ProductQuantizer. Ramil talked to Matthijs and got to understand that over 16 bits isn't really practical, but we can do 24 to be safe. Reviewed By: mengdilin Differential Revision: D62153881
|
This pull request was exported from Phabricator. Differential Revision: D62153881 |
mnorris11
force-pushed
the
export-D62153881
branch
from
2606d33
to
edab5d2
Compare
|
This pull request has been merged in a4ebcb1. |
Closed
2 tasks
aalekhpatel07
pushed a commit
to aalekhpatel07/faiss
that referenced
this pull request
Oct 17, 2024
…rch#3833) Summary: Pull Request resolved: facebookresearch#3833 size_t expands to unsigned long int, so any left shift more than 31 means ksub overflows. So, we can add a check right before it is constructed in ProductQuantizer. Ramil talked to Matthijs and the outcome is that 16 bits isn't really practical, but we can do the check for 24 to be safe. Reviewed By: kuarora, mengdilin Differential Revision: D62153881 fbshipit-source-id: 721db6bf6ad5dd5d336b4498f4750acc4059310c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
size_t expands to unsigned long int, so any left shift more than 31 means ksub overflows. So, we can add a check right before it is constructed in ProductQuantizer.
Ramil talked to Matthijs and the outcome is that 16 bits isn't really practical, but we can do the check for 24 to be safe.
Differential Revision: D62153881