add get_version() for c_api. #3688
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D60207739 |
|
This pull request was exported from Phabricator. Differential Revision: D60207739 |
bshethmeta
added a commit
to bshethmeta/faiss
that referenced
this pull request
Jul 25, 2024
Summary: Pull Request resolved: facebookresearch#3688 Test PR. Differential Revision: D60207739
bshethmeta
force-pushed
the
export-D60207739
branch
from
8831a35
to
67bfbee
Compare
bshethmeta
added a commit
to bshethmeta/faiss
that referenced
this pull request
Jul 25, 2024
Summary: Pull Request resolved: facebookresearch#3688 Test PR. Differential Revision: D60207739
bshethmeta
force-pushed
the
export-D60207739
branch
from
67bfbee
to
50bc767
Compare
|
This pull request was exported from Phabricator. Differential Revision: D60207739 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D60207739 |
bshethmeta
added a commit
to bshethmeta/faiss
that referenced
this pull request
Jul 25, 2024
Summary: Pull Request resolved: facebookresearch#3688 Test PR. Differential Revision: D60207739
bshethmeta
force-pushed
the
export-D60207739
branch
from
50bc767
to
d81b59b
Compare
Enet4
reviewed
Jul 25, 2024
|
This pull request was exported from Phabricator. Differential Revision: D60207739 |
bshethmeta
added a commit
to bshethmeta/faiss
that referenced
this pull request
Jul 25, 2024
Summary: Pull Request resolved: facebookresearch#3688 Looks like our previous changes only modified the cpp API. Not the c_api like the request wanted. This attempts to add faiss_get_version to c_api Differential Revision: D60207739
bshethmeta
force-pushed
the
export-D60207739
branch
from
d81b59b
to
7ed436e
Compare
Summary: Pull Request resolved: facebookresearch#3688 Looks like our previous changes only modified the cpp API. Not the c_api like the request wanted. This attempts to add faiss_get_version to c_api Differential Revision: D60207739
|
This pull request was exported from Phabricator. Differential Revision: D60207739 |
bshethmeta
force-pushed
the
export-D60207739
branch
from
7ed436e
to
3d0f27f
Compare
|
This pull request has been merged in 4cfa638. |
ketor
pushed a commit
to dingodb/faiss
that referenced
this pull request
Aug 20, 2024
Summary: Pull Request resolved: facebookresearch#3688 Looks like our previous changes only modified the cpp API. Not the c_api like the request wanted. This attempts to add faiss_get_version to c_api Reviewed By: ramilbakhshyiev Differential Revision: D60207739 fbshipit-source-id: 07184aeae92a154bb3f440279595077f002851f3
aalekhpatel07
pushed a commit
to aalekhpatel07/faiss
that referenced
this pull request
Oct 17, 2024
Summary: Pull Request resolved: facebookresearch#3688 Looks like our previous changes only modified the cpp API. Not the c_api like the request wanted. This attempts to add faiss_get_version to c_api Reviewed By: ramilbakhshyiev Differential Revision: D60207739 fbshipit-source-id: 07184aeae92a154bb3f440279595077f002851f3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Test PR.
Differential Revision: D60207739