-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix faiss swig build with version > 4.2.x #3315
Closed
Commits on Mar 26, 2024
-
Configuration menu - View commit details
-
Copy full SHA for a4b50e3 - Browse repository at this point
Copy the full SHA a4b50e3View commit details -
Fix faiss swig build with version > 4.2.x
Summary: Currently, faiss can't build with swig version > 4.2.x. As the #3239 mentioned. Swig removed the support for 32bit swig/swig@9fb3a49. So SWIGTYPE_p_unsigned_long_long isn't supported any more. In this diff, we are going to remove the unsupported type from Faiss swig. Test Plan: STEP 1: create a new conda env ``` conda create --name faiss_swig conda activate faiss_swig ``` STEP 2: install dependecies from conda-forge ``` conda install -y -q python=3.11 cmake make swig mkl=2023 mkl-devel=2023 numpy scipy pytest gxx_linux-64 sysroot_linux-64=2.28 -c conda-forge ``` STEP 3: CMAKE ``` cmake -B build \ [system] -DBUILD_TESTING=ON \ -DBUILD_SHARED_LIBS=ON \ -DFAISS_ENABLE_GPU=OFF \ -DFAISS_ENABLE_RAFT=OFF \ -DFAISS_OPT_LEVEL=avx512 \ -DFAISS_ENABLE_C_API=ON \ -DPYTHON_EXECUTABLE=$(which python) \ -DCMAKE_BUILD_TYPE=Release \ -DBLA_VENDOR=Intel10_64_dyn \ -DCMAKE_CUDA_FLAGS="-gencode arch=compute_75,code=sm_75" \ . ``` STEP 4: build ``` make -C build -j faiss && make -C build -j swigfaiss ``` /var/folders/n5/8sm28y7j7hl8w4xdtl7r_33w0000gn/T/TemporaryItems/NSIRD_screencaptureui_AjUh4J/Screenshot 2024-03-25 at 12.21.25 AM.png
Configuration menu - View commit details
-
Copy full SHA for 1fcb3de - Browse repository at this point
Copy the full SHA 1fcb3deView commit details -
<Replace this line with a title. Use 1 line only, 67 chars or less>
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags:
Configuration menu - View commit details
-
Copy full SHA for f235edb - Browse repository at this point
Copy the full SHA f235edbView commit details -
Configuration menu - View commit details
-
Copy full SHA for a3498c0 - Browse repository at this point
Copy the full SHA a3498c0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 673f48a - Browse repository at this point
Copy the full SHA 673f48aView commit details
Commits on Mar 27, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 8de8d7e - Browse repository at this point
Copy the full SHA 8de8d7eView commit details -
Configuration menu - View commit details
-
Copy full SHA for c89a574 - Browse repository at this point
Copy the full SHA c89a574View commit details
Commits on Mar 28, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 6598d49 - Browse repository at this point
Copy the full SHA 6598d49View commit details -
Configuration menu - View commit details
-
Copy full SHA for 961713a - Browse repository at this point
Copy the full SHA 961713aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8a17e06 - Browse repository at this point
Copy the full SHA 8a17e06View commit details -
Configuration menu - View commit details
-
Copy full SHA for bd04ec6 - Browse repository at this point
Copy the full SHA bd04ec6View commit details -
Configuration menu - View commit details
-
Copy full SHA for c1c8ee3 - Browse repository at this point
Copy the full SHA c1c8ee3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9ce9a67 - Browse repository at this point
Copy the full SHA 9ce9a67View commit details -
Configuration menu - View commit details
-
Copy full SHA for 50144f5 - Browse repository at this point
Copy the full SHA 50144f5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4432541 - Browse repository at this point
Copy the full SHA 4432541View commit details -
Configuration menu - View commit details
-
Copy full SHA for 449964e - Browse repository at this point
Copy the full SHA 449964eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 19b73ef - Browse repository at this point
Copy the full SHA 19b73efView commit details
Commits on Mar 29, 2024
-
Configuration menu - View commit details
-
Copy full SHA for cb243fc - Browse repository at this point
Copy the full SHA cb243fcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4a95427 - Browse repository at this point
Copy the full SHA 4a95427View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6b16647 - Browse repository at this point
Copy the full SHA 6b16647View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.