Add asset integrity check for asset downloads #840
Merged
+49
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do? Please describe:
This PR adds a file integrity check for tokenizers, models, and datasets to ensure they were downloaded properly with a SHA-1 checksum. If the checksum listed on the asset card doesn't match, the
download_manager
will raise anAssetDownloadError
. If there is no listed checksum on the asset card, thedownload_manager
will proceed like normal but make a call tolog.warning
about the missing checksum field.Fixes #839
Does your PR introduce any breaking changes? If yes, please list them:
Adds an additional
checksum
parameter to thedownload_manager
's methods for downloading tokenizers, models, and datasets.Check list: