-
Notifications
You must be signed in to change notification settings - Fork 5
Mephisto LIGHT worker task #318
base: main
Are you sure you want to change the base?
Conversation
Wiring front to back
Wiring front to back
Backend fixes and quests
small intro fix (actor_name)
Pre alpha fixes2
adding common sense + world builder code
* added gameplay task view * added gameplay task view * fixed message transmission in both gameapp reducer and task redux-slice * removed boilerplate * placed topmessage function at top of reducer
* added assets * added assets * added PreviewView, added assets to preview view, began styling preview view * added preview copy and screenshots, added instruction modal, added task copy from quip
Hi @JackUrb! Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention. You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
Copy of (#283) post-merge
Overview
Following up on #282, this PR updates the task frontend introduced in #281 to now be in a Mephisto-task format. Note, this now requires using Mephisto version 1.0.0.
Implementation
Due to how Mephisto tasks build, I had to rearrange a number of folders, configure webpack, change react versions, etc. to get things running. That's most of the churn of this PR. Additionally:
AppRouter
component with aLIGHTAppTaskFrame
component, which does the type of routing that a Mephisto task expects. This component is also responsible for requesting the correct authorization key for a given worker, and passing the synthesized URL to the underlying task component.Task
component to receive a passed URL and the submit function, though the latter is currently unused right now.run_task.py
script that actually launches the mephisto job, requiring apreauth_secret
that needs to be shared between the server launch and the Mephisto task. This allows Mephisto to sign the worker's auth token properly.Some notes here, I've left a few messy components in the
LIGHTAppTaskFrame
file. These should probably be refactored out. Also unfortunately @JustinPinero I expect there to be a significant amount of manual churn merging your onboarding flow, considering some fairly substantial folder thrash required to get Mephisto up-and-running. When you merge onboarding into this, you'll have to add anonboarding_qualification
to thelocal
yaml configuration in order to see your onboarding view (after you insert it in theisOnboarding
branch ofLIGHTAppTaskFrame
). See thelocal_test.yaml
file incrowdsourcing/dialogues/multi_party_chat/hydra_confs
folder for an example.Testing
Navigate to the desired location: