Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple Valid Objects #39

Open
bdhingra opened this issue Dec 30, 2020 · 4 comments
Open

Multiple Valid Objects #39

bdhingra opened this issue Dec 30, 2020 · 4 comments

Comments

@bdhingra
Copy link

The "Language Models as Knowledge Bases" paper, in Section 4.4, mentions that the evaluation deals with multiple valid objects for the same subject and relation pair. Specifically, valid objects other than the one which is being tested are removed from the ranked list of answers before computing the metrics. However, the TREx data released in this repository only includes one object per tested fact, even for queries where multiple valid answers do exist (based on my browsing of Wikidata). So, does the LAMA evaluation account of multiple valid objects? If yes, how does it do that given that the multiple objects are not in the data.

@cloudygoose
Copy link

Hi, I have maybe the same question here, in the paper (sec4.4) you said you removed some candidates for n-m relations, however, in the code, i did not find anything related to this. (i did not see anything special is done for n-m relations), did i miss anythign?
Thanks!
image

@ethanjperez
Copy link

@bdhingra @cloudygoose were you able to figure this out? I also have the same question

@cloudygoose
Copy link

@ethanjperez Sadly no, I still believe the multi-target problem is not addressed in the released code.
But, It's not hard to implement.

@gary-young
Copy link

I have the same question. I also wonder what the "training data" means in the paragraph. I think the LAMA probe is used to detect whether the LMs can store the observed facts during training so I do not understand why we need to remove them.
For multiple valid objects, I believe it is easy to implement but it needs additional annotation in the datasets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants