Skip to content
This repository has been archived by the owner on Oct 31, 2023. It is now read-only.

question: reader loss #244

Open
PaulLerner opened this issue Feb 24, 2023 · 0 comments
Open

question: reader loss #244

PaulLerner opened this issue Feb 24, 2023 · 0 comments

Comments

@PaulLerner
Copy link

Hi,

I have trouble understanding this line in compute_loss in reader.py:

loss_tensor = loss_tensor.view(N, M, -1).max(dim=1)[0]

This keeps the maximum loss over all M passages, why? Why not summing or averaging?

Best regards,

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant