-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ubuntu 20.04 install gcc11 instead of gcc9 #10953
Comments
I note the recently folly is upgrade by 3fabdf5. Seems it requires gcc version >=10. |
@PHILO-HE Ok, looks like we have to move up gcc for Ubuntu 20.04 faster than expected. Recommended is using gcc11. We haven't run the recent upgraded folly with gcc9 so missed any potential issue. |
@PHILO-HE In fact, Ubuntu 20.04 has a few problems right now independent of gcc11.
This begs the question if we can discontinue supporting Ubuntu 20.04 as a build environment? |
@czentgr, thanks for your check! cc @majetideepak, @assignUser, @kgpai |
The first issue can be fixed by installing the missing package. I fixed the second issue by using |
@majetideepak, I agree to keep supporting ubuntu 20.04. @czentgr, could you help upgrade gcc for this os? |
@PHILO-HE Sure. I am working on a PR for that (where I found the additional issues). |
Description
When Velox starts building with C++20 standard the compiler toolchain needs to be updated and gcc11 will be the minimum supported version. Because Ubuntu 20.04 LTS is still around the setup script needs to change and install gcc11 (instead of keep installing gcc9).
Eventually, the CMake will enforce the supported compiler version.
The text was updated successfully, but these errors were encountered: