Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ubuntu 20.04 install gcc11 instead of gcc9 #10953

Closed
czentgr opened this issue Sep 9, 2024 · 7 comments
Closed

Ubuntu 20.04 install gcc11 instead of gcc9 #10953

czentgr opened this issue Sep 9, 2024 · 7 comments
Labels
enhancement New feature or request

Comments

@czentgr
Copy link
Collaborator

czentgr commented Sep 9, 2024

Description

When Velox starts building with C++20 standard the compiler toolchain needs to be updated and gcc11 will be the minimum supported version. Because Ubuntu 20.04 LTS is still around the setup script needs to change and install gcc11 (instead of keep installing gcc9).

Eventually, the CMake will enforce the supported compiler version.

@czentgr czentgr added the enhancement New feature or request label Sep 9, 2024
@PHILO-HE
Copy link
Contributor

PHILO-HE commented Oct 15, 2024

I note the recently folly is upgrade by 3fabdf5. Seems it requires gcc version >=10.

@czentgr
Copy link
Collaborator Author

czentgr commented Oct 15, 2024

@PHILO-HE Ok, looks like we have to move up gcc for Ubuntu 20.04 faster than expected. Recommended is using gcc11. We haven't run the recent upgraded folly with gcc9 so missed any potential issue.

@czentgr
Copy link
Collaborator Author

czentgr commented Oct 15, 2024

@PHILO-HE In fact, Ubuntu 20.04 has a few problems right now independent of gcc11.

  1. setup script is not installing CMake PkgConfig used by a few modules (RE2).
  2. Improve duplicated key error message #9374 added Gtest features (Throws) only available in Gtest 1.11 while system default in Ubuntu 20.04 is 1.10. So we'd need to move to a build&install for Gtest.

This begs the question if we can discontinue supporting Ubuntu 20.04 as a build environment?

@PHILO-HE
Copy link
Contributor

@PHILO-HE In fact, Ubuntu 20.04 has a few problems right now independent of gcc11.

  1. setup script is not installing CMake PkgConfig used by a few modules (RE2).
  2. Improve duplicated key error message #9374 added Gtest features (Throws) only available in Gtest 1.11 while system default in Ubuntu 20.04 is 1.10. So we'd need to move to a build&install for Gtest.

This begs the question if we can discontinue supporting Ubuntu 20.04 as a build environment?

@czentgr, thanks for your check! cc @majetideepak, @assignUser, @kgpai

@majetideepak
Copy link
Collaborator

majetideepak commented Oct 16, 2024

This begs the question if we can discontinue supporting Ubuntu 20.04 as a build environment?

The first issue can be fixed by installing the missing package. I fixed the second issue by using VELOX_ASSERT_THROW #11270
The Ubuntu 20.04 end of standard support in April 2025. We should support it until then.

@PHILO-HE
Copy link
Contributor

@majetideepak, I agree to keep supporting ubuntu 20.04. @czentgr, could you help upgrade gcc for this os?

@czentgr
Copy link
Collaborator Author

czentgr commented Oct 18, 2024

@PHILO-HE Sure. I am working on a PR for that (where I found the additional issues).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants