Preserve semicolons between call expressions and dead lambdas. #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This addresses #262 if I'm not mistaken? |
|
I'm going to import this so it's easier to review and test it on our repo. |
|
@cgrushko has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
cgrushko
reviewed
Feb 10, 2022
| prevLeaf is KtContainerNodeForControlStructureBody && | ||
| prevLeaf.text.isEmpty()) { | ||
| return false | ||
| } | ||
| val nextConcreteSibling = element.getNextSiblingIgnoringWhitespaceAndComments() | ||
| if (prevConcreteSibling is KtCallExpression && nextConcreteSibling is KtLambdaExpression) { |
There was a problem hiding this comment.
Can you add a comment with an example that this clause catches? it makes it easier to navigate the code afterwards.
It's possible that removing such semicolons can change the behaviour of the code by reinterpreting the dead lambda as a trailing lambda. This change also improves semicolon preservation when there are comments and whitespace adjacent to the semicolon.
|
@cgrushko has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's possible that removing such semicolons can change the behaviour of the code by reinterpreting the dead lambda as a trailing lambda.