-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Selector is not updated after error happens #1186
Comments
Hmm, when I click [Recover] button a second time it does recover. Does this issue reproduce with the #1132 fix in the nightly build? |
Hi @drarmstr. Yes, second time it's recover a value. You even can uncomment ItemLoadable and see that in reality selector value is changed after atom value changed. But I not sure how to install nightly build to check. When I do in my project
and then started my project I had an error in browser console:
So, do you have instructions how to install recoil from master? |
Hi, @drarmstr. I have to install nightly as Also, I created a repo with an example code, so maybe this would be helpful for you to investigate this issue. |
Hi. I also facing same problem. I update @leoblum example with the package from #496 (comment) and it seems not effect for double crash. Recoil version 0.4.1 + @timiscoding/recoil (recoil_early_rendering_2021 feature) |
Hah, I also make sandbox with React v18 and its working as expect– no double error showed. ✅ With React 18-alpha with @timiscoding/recoil (as expected) ❌ With React 18-alpha only Recoil (not working) So yeah, should we wait fix for React 17 or not? |
Closed with #1076 |
Version
recoil 0.4.0
react 17.0.0
Steps to reproduce
Expected behaviour
After error in selector when change atom value selector refetch new data.
Example
https://codesandbox.io/s/lucid-pasteur-o88bq?file=/src/index.js
Open console to see logs (set for atom and get for selector).
To reproduce click Next Id two times. Then close react error window and click Recover – you will see in logs that atom is set, but not get for selector and error happens again.
The text was updated successfully, but these errors were encountered: