Skip to content
This repository has been archived by the owner on Mar 3, 2020. It is now read-only.

Feature Request: Ability to Specify Custom Intervals for Connection Quality Classes #23

Open
sreejithr opened this issue Jun 15, 2016 · 3 comments

Comments

@sreejithr
Copy link

In our app, user bandwidth would never cross 150kbps since most of our users are in 2g and rarely in 3g. Consequently, the connection class is always in POOR.

  • Can we have this feature so that the library will be useful in my app?
  • Would changing the connection class speeds mess up the math in moving averages and hysteresis?
@sreejithr sreejithr changed the title Ability to Specify Custom Intervals for Connection Quality Classes Feature Request: Ability to Specify Custom Intervals for Connection Quality Classes Jun 15, 2016
@zlern2k
Copy link
Contributor

zlern2k commented Jun 18, 2016

Changing the thresholds doesn't affect the averaging math. Keep in mind that the averages are very noisy, so your thresholds should be at least a factor of ~3.5 apart; for instance 30, 100, 350. You should go ahead and change them to whatever makes sense for your app.

@sreejithr
Copy link
Author

@zlern2k But since the connection class speeds are hard-coded into constants, I can't change them without taking a fork. Shouldn't this be easier?

@manuelkch
Copy link

Any intention yet to remove them from the hard-coded part and make it configurable in the future? I'd like to make that configurable for a react-native bridge. Or should we continue with a fork?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants